zupfnoter icon indicating copy to clipboard operation
zupfnoter copied to clipboard

Pitch of a rest at end of repetition shall be the previous note

Open bwl21 opened this issue 9 years ago • 1 comments

Request

if a repeated section ends with a rest, the pitch of the rest shall not be the one of next note. This is because we do not continue to play at the next note but at the beginning of the repetition.

Therefore it is irritating to place the rest adjacent to the net note.

Solution

  1. set the pitch to the one of the previous note in case a repetition ends with a rest.
  2. investigate,
    • if the pitch of rests shall always be the one of the previous note.
    • behavior on variant endings
  3. refactor handling of pitch in rests, @previous_note, prev_pitch etc.

Status

  1. does not work if there are more than one rests at the end of the repeated section.
  2. does not work properly in case of variant ending

I guess the whole thing needs to be reworked. Even the code is hard to understand.

bwl21 avatar Aug 12 '16 07:08 bwl21

see also #58

bwl21 avatar Aug 18 '16 10:08 bwl21