Brian Wilkerson

Results 612 comments of Brian Wilkerson

We have already [implemented this as a warning](https://dart-review.git.corp.google.com/c/sdk/+/168561), but have been unable to land it because it's too big a breaking change. We have discussed implementing this as a lint,...

> This is a really useful feature for JS interop, so it'd be great if we can get this or an annotation-driven version of this. One significant consideration is that...

> I'm not opposed to the annotation-based model, but not having transitivity like I mentioned above is not ideal, but I'll still take it. Maybe it is a high ask...

> ... introduced implicit control flow into Dart. If I understand you definitions, Dart has always had implicit control flow because of exceptions. Looking at a normal method invocation, it...

Thanks for the suggestion. If I remember correctly, the original rationale for not supporting checked exceptions was a belief that having any unchecked exceptions effectively negates the value of supporting...

> Should they be resolved instead within the `@template`, and then the referenced elements are carried over to the comment with `@macro`? I would also have expected that to be...

> The analyzer has a different algorithm with `Scope` that makes for (IMO) better reference resolving ... I agree. Using the language-defined scope lookup makes more sense, especially given that...

We already support this behavior in the analysis server for hovers. The analyzer has all the information it needs to allow us to look up the inheritance chain until we...

It shouldn't be a problem to add an annotation to mark an unstable getter. Just to double check though, are we sure we want a lint with an annotation to...

Since the last comment on this PR we've moved the linter sources into the `sdk` repo and stopped accepting PRs against this repo. Would you mind converting this into a...