Bill Wendling
Bill Wendling
On Thu, Sep 11, 2014 at 3:07 AM, Ali Gholami Rudi [email protected] wrote: > From-imports are probably replaced with absolute imports in > MoveModule._change_moving_module() of rope/refactor/move.py: > To make sure...
On Thu, Sep 11, 2014 at 10:38 PM, Ali Gholami Rudi wrote: > > Bill Wendling [email protected] wrote: > > > Unfortunately, that didn't work. I suspect that part of...
On Sun Sep 14 2014 at 1:52:06 PM Bill Wendling [email protected] wrote: > P.S. I've attached the actual diff for your perusal. Just to clarify, the diff I attached is...
On Mon, Sep 15, 2014 at 9:14 AM, Ali Gholami Rudi [email protected] wrote: > Bill Wendling [email protected] wrote: > > > > There are ways of preserving from-imports but it...
Do you have a testcase for this?
@lizawang Please run YAPF over your changes. This is looking good. However, this change is massive and very hard to review. Could you split it up into one PR per...
There is a `SPACES_BEFORE_COMMENT` option, which aligns comments. Aligning assignment operators could be done similarly I suppose.
+1 this idea (whatever syntax it takes). Having the ability to write free-flowing text in the text protobuf is great for people who want to use protobufs but still have...
Hmm...it does appear to be [an option](https://github.com/google/protobuf/blob/d5fb408ddc281ffcadeb08699e65bb694656d0bd/src/google/protobuf/io/tokenizer.h#L239), but it's discouraged. I don't know the reasoning for it.
Hmm...Using `0` to indicate that no column limit applies is an interesting feature. However, it could backfire. If you have a large data literal, it'll be placed on one line....