gallery3 icon indicating copy to clipboard operation
gallery3 copied to clipboard

Commit #e3dc6b0 breaks full size image viewing

Open Seanst3r opened this issue 2 years ago • 0 comments

Hi. I couldn't view full size images in my gallery. There's a google discussion about it so I'm not alone.

Commit # e3dc6b0 is titled "handle full URL comparison better for proxy access checks" This is an edit to modules/gallery/controllers/file_proxy.php

Line 49 of the file seems to be the problem. $compare_uri = url::file(ltrim($request_uri,'/'));

this changes the url being checked gallery/var/albums/whatever.jpg into gallery/gallery/var/albums/whatever.jpg

And then it throws an exception because the path doesn't start with gallery/var

When logged in as an admin I tried to directly access a full size image url and received a gallery page fairly well describing the exception that was thrown.

It's not clear what this commit was meant to fix. Maybe a "proxy access" uses a different request_uri that lacks a leading "gallery/" prefix? Maybe it was only meant to clean up a request with a leading slash. (RewriteBase / )

My solution was to set compare_uri = $request_uri; (or just revert this whole commit)

Regards, Sean

Seanst3r avatar Oct 18 '22 17:10 Seanst3r