bwapi icon indicating copy to clipboard operation
bwapi copied to clipboard

Published 20 hours ago • verified publisher icon bwapi

Use high-resolution clock when computing lastEventTime

Open bmnielsen opened this issue 2 years ago • 3 comments

This is a very simple PR intended to address the timer resolution issue discussed on #860.

I created the PR against the main branch since I think it makes sense to patch this in BWAPI 4.X, seeing as how timeouts continue to be an issue in tournaments held since the issue was raised.

bmnielsen avatar Apr 11 '22 12:04 bmnielsen

:white_check_mark: Build bwapi 4.4.0.403 completed (commit https://github.com/bwapi/bwapi/commit/8283b22dee by @bmnielsen)

bwapi-build avatar Apr 11 '22 12:04 bwapi-build

Can you rebase on develop?

N00byEdge avatar Apr 11 '22 23:04 N00byEdge

Can you rebase on develop?

Isn't that where BWAPI 5 development is happening? As far as I can tell, lastEventTime hasn't been implemented yet there (the field is in the protobuf spec and available through getters, but doesn't appear to be set anywhere).

bmnielsen avatar Apr 12 '22 05:04 bmnielsen