PIDtoolbox icon indicating copy to clipboard operation
PIDtoolbox copied to clipboard

Error in PTload

Open AndreySemjonov opened this issue 4 years ago • 14 comments

For EmuFlight logs on latest 0.42 PIDtoolbox getting error image Do not have same issue with 0.392

Here log: 8.zip

If this is issue on EMUF side than we can fix it.

AndreySemjonov avatar Jun 24 '21 09:06 AndreySemjonov

I see the error. Dmin and FF strings empty. Fixed and will be part of next release. PTB_FIGS_EMUlogWontWorkPTB0 42xx_24-Jun-2021-1

bw1129 avatar Jun 24 '21 12:06 bw1129

ah, here's a version with the fix. Go ahead and try this one. https://www.dropbox.com/s/n2njf6ys47g5fky/main.zip?dl=0

bw1129 avatar Jun 24 '21 12:06 bw1129

Thanks. It is OK now

AndreySemjonov avatar Jun 24 '21 12:06 AndreySemjonov

Excellent!

Keep this 'issue' here so others can download the fix if needed.

bw1129 avatar Jun 24 '21 13:06 bw1129

hi , can you provide the corrected file for MAC also ?

massimilianodossi avatar Jun 30 '21 09:06 massimilianodossi

No prob. I’ll post it here in a bit. New release in the works as well soon

bw1129 avatar Jun 30 '21 10:06 bw1129

emu fix for mac users. you also get a few extra fixes for free with this version ;-) https://www.dropbox.com/s/d357g4klnhe5wyy/main_forMac.zip?dl=0

bw1129 avatar Jun 30 '21 14:06 bw1129

sorry but the ptload error persist

massimilianodossi avatar Jun 30 '21 15:06 massimilianodossi

I just ran it using the emu log posted above and it works fine. you must have a different issue. normally this doesnt matter, but delete the old PIDtoolbox.app then try the logfile above (linked in the first post at beginning of this issue). also drop a link to your logfile

bw1129 avatar Jun 30 '21 18:06 bw1129

while trying to open an iNAV log, I get a new error (was getting the one posted above before): Error in PTload unrecognized variable name 'setpoint_0_'.

So I guess you fixed the variable names, but not for the "special" iNAV ones. maybe a simple fix? https://drive.google.com/file/d/1hsqMLL4p9JUdd-WQzhzrnfLlov_oe-t1/view?usp=sharing

EDIT: I managed to open the file without error by changing the header in the .txt iNAV log: rcdata[X] -> setpoint[X] axisRate[X] -> axisF[X]

Now the step response works for iNAV. Great success.

charlesmarseille avatar Jul 01 '21 21:07 charlesmarseille

PTB 0.4+ went through complete overhaul. The file importing functions had to be rewritten to accommodate the new multi-file structure. As a result I had to make a decision how complicated I wanted it to be and I opted for a very simplified approach. Compare PTload and PTimport now compared to v0.392 for example. So I don’t rename anything now. It comes is as Blackbox_decode exports it and that’s all determined by the main firmware developer. Both BF and EMU use the same basic variable names for set point etc, but INAV doesn’t. So given the small INAV user base I decided to stop support for INAV. I made a post in INAV asking who uses PTB and got like 3-4 responses. PTB v0.392 still works for INAV users so that’s where I left it. If more INAV users expressed interest I’d work at it.

bw1129 avatar Jul 01 '21 22:07 bw1129

Yes, I saw your ask for the interest in iNAV users, not so many responses. I then tried 0.392, and got the same error. Just by changing these 2 header variables I got it working though. Thanks for your great work, really enjoy that visualisation of the data.

charlesmarseille avatar Jul 01 '21 23:07 charlesmarseille

Hey whatever it takes to help you keep supporting emu we would be happy to help.

Quick-Flash avatar Jul 01 '21 23:07 Quick-Flash

Hey thanks Kevin! So far so good. I think as long as the main variable names come out of bb_decode the same we’re generally good to go.

bw1129 avatar Jul 02 '21 11:07 bw1129