julius
julius copied to clipboard
bvschaik
[Visual bug] Misaligned image layers
Nitpicky visual bugs (happens on vanilla C3 too): image layers of some working buildings are slightly shifted compared to the same buildings when inactive.
-
Amphitheater ID 3050 is 1 pixel too far to the left (compared to ID 3039)
-
Lion Pit : ID 3101 to ID 3118 are 1 pixel to low (compared to ID 3100)
To reproduce, simply switch between Global Entertainment overlay and City map (these 2 happen on Augustus too).
- Engineer's post
ID 3282 to 3291 are 1 pixel too high (compared to ID 3281)
This one has been fixed a long time ago in Augustus (April 2022), I forgot to report it first for Julius.
I think the Theater is also misaligned in Julius, can you confirm please?
The problem with fixing these is that the offsets are inside the SG2 files. Not sure how Augustus fixed those -- by hardcoding image ID + x/y offset in the code?
Not sure how Augustus fixed those -- by hardcoding image ID + x/y offset in the code?
Found the commit that fixed the roof of active Engineer's post: https://github.com/Keriew/augustus/commit/2923909686013204dee49d33efd3f8ebc1138ab8 Amphitheater and Lion Pit have not been fixed.
I think the Theater is also misaligned in Julius, can you confirm please?
I see nothing wrong with the Theater. All's good.
The problem with fixing these is that the offsets are inside the SG2 files. Not sure how Augustus fixed those -- by hardcoding image ID + x/y offset in the code?
Yes the changes were hard coded. Not the best solution but it works!
Should we fix this? (doing it manually on core/image.c) or do I keep this to Augustus?
Tough one. It does look better if fixed, even though the fix itself is quite ugly... Let's go ahead and fix.