Brian Kimball

Results 24 comments of Brian Kimball

Awesome! I will try to get this cleaned up over the weekend.

Not perfect yet but I think tests are working again. Issue caused because the Parent-Child Injection causes circular dependency. The demo is a bit contrived but it is similar to...

I think everything is done and working, and I add docs and some cypress test. The issues with select are caused by the Angular CDK DragDrop swallows all mouse events....

I think i have updated everything correctly, sorry about my poor grammar skills ;)

ok, sorry about those missed comments, I wish GitHub had an easy way to view them in a list. I resolved the old outdated comments.

No worries, updated. I also added the `*ngIf="isDesktop"` to hide the `drag-and-drop` demo on mobile. Yeah the click to select functionality doesn't work because of the `DragDropModule` the `cdkDrag` directive...

I guess a solution could be to pass mouse-events from the selectItem as a "CustomEvent" or pass through to the parent via the reference we just added via DI.

Yeah, Cypress error was because the "Item" animates while you drag to reorder, and because the demo isn't at the bottom of the screen anymore the `scrollIntoView` causes some issue...

ugh... yeah, i see it, it is caused because i hide `app-task` which has the `dtsSelectItem` but the `cdkDrag` container is is still in the dom... I can fix this...

Ok this fix is not great... Its kindof a hack, but since the `cdkDrag` really only manipulates the dom based on the element you are dragging and just hide the...