react-virtualized icon indicating copy to clipboard operation
react-virtualized copied to clipboard

React 18 Support

Open Miikis opened this issue 2 years ago • 17 comments

Feature Request

Provide as much information as possible about your requested feature. Here are a few questions you may consider answering:

  • What's your use case? (Tell me about your application and what problem you're trying to solve.) Not sure but I think the virtualization is using react's synchronous dom-rendering apis still.

  • What interface do you have in mind? (What new properties or methods do you think might be helpful?) Same interface is fine — just need React 18 support.

  • Can you point to similar functionality with any existing libraries or components? (Working demos can be helpful.) Not sure if react-window has a similar incompatibility w/ React 18

Miikis avatar Apr 30 '22 15:04 Miikis

Used react-virtualized with React 18 two days ago. Why do you think it doesn't work?

tippfelher avatar Apr 30 '22 18:04 tippfelher

@tippfelher some features might work but I think some operations that have to do w/ figuring out the size of DOM elements (e.g. CellMeasurer) are performed synchronously and/or in an incompatible way w/ React 18. But this is just a guess at this point — would be nice to get some insight from @bvaughn on this.

The real answer to your question, I guess, is I tried to upgrade to [email protected] while using [email protected] and the virtualized grid — where we're def using features that would require determining cell-size — wouldn't render.

On a whim, I also tried [email protected] but it led to the same results. That alpha release is available on npm but there's no mention of it in the changelogs — so I don't what's supposed to be in it.

Miikis avatar Apr 30 '22 19:04 Miikis

The CellMeasurer does support using a ref to measure its child instead of the default way. I think that's the recommended way that's compatible with future versions of React.

distinctdan avatar May 04 '22 14:05 distinctdan

I made it work using npm install react-virtualized --legacy-peer-deps

marcjoancr avatar May 07 '22 10:05 marcjoancr

I made it work using npm install react-virtualized --legacy-peer-deps

This also worked for me

Flouwrian avatar May 11 '22 14:05 Flouwrian

any plans for a release that eliminates the need for --legacy-peer-deps

andrewluetgers avatar May 12 '22 21:05 andrewluetgers

+1 to cutting a new release, looks like the version upgrade has been merged a month ago, would be very very nice to be able to use this lib again

avegancafe avatar May 24 '22 15:05 avegancafe

does this has anything to do with issue #1737?

yelnyafacee avatar Jun 09 '22 03:06 yelnyafacee

When i use List in my project with React 18 + TypeScript, i got an error like this: https://github.com/bvaughn/react-virtualized/issues/1739

gormonn avatar Aug 02 '22 10:08 gormonn

Any update on the request?

skye-levit avatar Sep 20 '22 07:09 skye-levit

Any update on this?

DrkCoater avatar Oct 19 '22 22:10 DrkCoater

Any update?

ahrakos avatar Oct 24 '22 12:10 ahrakos

there wont be any this package is dead, its been for many month now, the author have no intention to update it, even if it is possible

yelnyafacee avatar Oct 24 '22 15:10 yelnyafacee

I made it work using npm install react-virtualized --legacy-peer-deps

This worked for me.

AgomohC avatar Jan 29 '23 15:01 AgomohC

My TypeScript is very unhappy. Took me a bit to realize that it's because this lib doesn't support React 18 yet - I was getting errors the same as #1739 (which seems to be closed, even though the issue is still present on the latest release). Guess I'm going to go use something else.

hiddenist avatar Apr 27 '23 00:04 hiddenist

My TypeScript is very unhappy. Took me a bit to realize that it's because this lib doesn't support React 18 yet - I was getting errors the same as #1739 (which seems to be closed, even though the issue is still present on the latest release). Guess I'm going to go use something else.

what do you have as alternative?

muhaimincs avatar Jul 05 '23 14:07 muhaimincs

My TypeScript is very unhappy. Took me a bit to realize that it's because this lib doesn't support React 18 yet - I was getting errors the same as #1739 (which seems to be closed, even though the issue is still present on the latest release). Guess I'm going to go use something else.

what do you have as alternative?

Try react virtuoso https://www.npmjs.com/package/react-virtuoso

AgomohC avatar Jul 05 '23 15:07 AgomohC