react-resizable-panels icon indicating copy to clipboard operation
react-resizable-panels copied to clipboard

BugFix: Global cursor style reset on unmount

Open TAGC opened this issue 11 months ago • 3 comments

Fixes #308.

This PR updates the PanelResizeHandle component to call resetGlobalCursorStyle when unmounted. This should prevent the cursor from indefinitely retaining the "resize" style if the component is unmounted as a panel is being resized.

I've tested out these changes locally and they appear to resolve the issue.

TAGC avatar Mar 06 '24 12:03 TAGC

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-resizable-panels ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 8:31pm

vercel[bot] avatar Mar 06 '24 12:03 vercel[bot]

Just an update on my end - work on this has been deprioritised as the team for the other frontend have found a workaround for the issue they were experiencing, and I've had higher priority stuff come through. I'd still like to continue on this when I get a chance, though.

TAGC avatar Mar 11 '24 11:03 TAGC

Thanks for the update!

bvaughn avatar Mar 11 '24 12:03 bvaughn

Hi @bvaughn, would you be able to re-review this when you get a chance? It's not critical, but it would be useful for my hackday project.

TAGC avatar Jun 25 '24 10:06 TAGC

Version 2.0.20 just deployed with this change.

bvaughn avatar Jul 02 '24 20:07 bvaughn

Thanks for taking this forward. I've updated my project to use v2.0.20 of this package and it's looking good to me :)

TAGC avatar Jul 04 '24 13:07 TAGC