js-worker-search icon indicating copy to clipboard operation
js-worker-search copied to clipboard

Relax uuid dependency

Open jeremyzahner opened this issue 5 years ago • 2 comments

This PR should solve various problems within earlier versions of uuid.

Example: https://github.com/kelektiv/node-uuid/issues/252

jeremyzahner avatar Aug 05 '19 09:08 jeremyzahner

Did you test this?

This library uses the uuid package like so:

import uuid from "uuid";

uuid.v4();

The docs for v3 of the uuid package show usage as:

const uuidv4 = require('uuid/v4');
uuidv4();

Those don't look compatible.

bvaughn avatar Aug 05 '19 15:08 bvaughn

@bvaughn Yes. Technically, it still works for v2 and v3 of the uuid package. It is deprecated thou.

[Deprecation warning: The use of require('uuid') is deprecated and will not be supported after version 3.x of this module. Instead, use require('uuid/[v1|v3|v4|v5]') as shown in the examples below.]

We could change the usage now. This would break compatibility with v2 (of uuid).

jeremyzahner avatar Aug 08 '19 13:08 jeremyzahner