Brian Vaughn
Brian Vaughn
Resolved in #19827
Re-opening because this was reverted again.
Feel free, @Eric0926. I'm a little skeptical about landing this change again though, given we've had to revert it twice. 😅 But if you're willing to do a lot of...
That's why the issue is still open, @alleksei37.
No. If there was a simple fix that just needed to be merged, it would have been merged already. Both previous attempts to fix this have needed to be reverted...
@prsmahajan You can find an architecture overview doc about how DevTools works here: https://github.com/facebook/react/blob/master/packages/react-devtools/OVERVIEW.md And instructions for how to build and test the extension here: https://github.com/facebook/react/tree/master/packages/react-devtools-extensions#local-development Beyond that, this would...
If you'd like to, please do.
> Set REACT_DEVTOOLS_GLOBAL_HOOK environment is not a good idea because https://github.com/pmmmwh/react-refresh-webpack-plugin/issues/475 Right. `__REACT_DEVTOOLS_GLOBAL_HOOK__` is a global variable (because of how the extension works) but it should be thought of as...
@gaearon Maybe worth editing that old message to remove the recommendation (or clarify that it _technically works_ but we don't _recommend_ it) if it's causing confusion? Overriding the hook feels...