Theodore Salvo

Results 23 comments of Theodore Salvo

Can you confirm your output using the workshop from today? I get the expected output.

This issue is on hold while we wait for EKS to support metrics-server.

Let's update the build script to set `EKS_CLUSTER_NAME` by default, but also provide instructions in the README about how to overwrite.

The scripts are hosted in S3 since the CloudFormation templates also must be in S3. The logic was to have everything you need _before_ cloning the repository in the S3...

Requesting to take this one as a first-time contributor (in code) to grpc-go. (Still pumped from KubeCon NA 2022)

@easwars Looking at the script, what's the difference between _legacy sources_ (Generates sources without the embed requirement) and _sources_ (Generates only the new gRPC Service symbols). What's the "embed requirement"?...

I did try moving v1alpha to use the protobuf from [grpc-proto/grpc/reflection/v1alpha](https://github.com/grpc/grpc-proto/blob/master/grpc/reflection/v1alpha/reflection.proto) but it's missing a `go_package` directive. ``` WARNING: Missing 'go_package' option in "grpc/reflection/v1alpha/reflection.proto" ``` I see that [v1 has...

From #5773: > the implementation must import both packages (and import alias them appropriately, something like reflectionv1pb and reflectionv1alphapb), and export both services Should there be two separate implementations--one for...

@dfawley Since we'd eventually want to move v1alpha to v1, should we instead wrap this into an interface and you can pass in either a v1alpha or v1 proto?

> Are there well established OCI registries that you can easily operate though? > > I ask, because we are on-prem and containers registry are one of the few things...