sso icon indicating copy to clipboard operation
sso copied to clipboard

*: statsd should be optional

Open loganmeetsworld opened this issue 7 years ago • 5 comments

Not all environments may have need for metrics collection, as such the following options should be optional or have defaults:

  • STATSD_HOST
  • STATSD_PORT

loganmeetsworld avatar Aug 22 '18 12:08 loganmeetsworld

Would work to expose metrics for pulling by Prometheus ever be accepted? At my work we've been eliminating our statsd infrastructure and while sso looks promising, the fact that its metrics are statsd (pushed) instead of pull/scrape-based is a big :-1:.

eriksw avatar Sep 06 '18 16:09 eriksw

@eriksw yes! We have looked into using Prometheus as well. Ideally we'd love to support both. Contributions on this front are more than welcome!

loganmeetsworld avatar Sep 06 '18 17:09 loganmeetsworld

Similarly need Prometheus metrics rather than statsd. I may be able to tackle this.

sporkmonger avatar Sep 07 '18 00:09 sporkmonger

I will probably take a first pass at simply setting up a set of statsd_exporter mappings for Prometheus as that doesn't require code changes.

sporkmonger avatar Sep 08 '18 07:09 sporkmonger

@sporkmonger How's it going with that? I'd also be happy to contribute Prometheus support, and metrics should absolutely be optional. I just don't want to tackle it if you're on it.

namliz avatar Oct 04 '18 23:10 namliz