sso icon indicating copy to clipboard operation
sso copied to clipboard

Fixed handle errors when reading HTTP/1 request smuggling

Open imhunterand opened this issue 1 year ago • 0 comments

A request smuggling attack is possible when using MaxBytesHandler. When using MaxBytesHandler, the body of an HTTP request is not fully consumed. When the server attempts to read HTTP2 frames from the connection, it will instead be reading the body of the HTTP request, which could be attacker-manipulated to represent arbitrary HTTP2 requests.

Not much that can be done now, but this essentially introduced a DOS vector into the http2 library without any release notes. While the comment is helpful, most users probably don't read the full diff of changes in core libraries like this. It would be nice to have more visibility into unsafe changes, or to make them opt-in, in the future.

imhunterand avatar Feb 15 '24 14:02 imhunterand