sso Add an option to skip sign in screen and go straight to logging in with oauth provider

Describe the bug

Setting SkipProviderButton using SKIP_PROVIDER_BUTTON=true in the environment doesn't do anything.

Looking at the code it just shoves it into a struct and never touches it again.

Expected behavior

I would expect it to, as the comment in the code says, just go directly to Google, and skip the whole "sign in to" screen (at least that is how I read that)

Dec 12 '18 07:12 digitalresistor

Thank you for finding this bug @bertjwregeer, this is most likely a feature that existed in oauth2_proxy that we did not end up keeping in sso, and never prioritized implementing. Is this a feature that you are looking to use?

Dec 14 '18 02:12 shrayolacrayon

This is not a feature that we intend to implement so we are going to remove the confusing environment variable. Thanks for flagging this @bertjwregeer.

Dec 14 '18 17:12 loganmeetsworld

I certainly would have liked to use it, we have a bunch of other applications that use Oauth2 through Google and they redirect to Google and back directly without going through an extra screen.

That being said, it's not a huge issue.

Dec 14 '18 17:12 digitalresistor

Since in its current state having this field is confusing since it doesn't actually do anything we think it makes sense to remove it, but I'm going to rename this issue to be a feature request for this functionality, please feel free to edit the description to add more detail if necessary.

Dec 14 '18 17:12 shrayolacrayon

:+1:

Dec 14 '18 17:12 digitalresistor