deadlinks icon indicating copy to clipboard operation
deadlinks copied to clipboard

Whoud you mind to add an `timeout` argument?

Open Karobben opened this issue 3 years ago • 4 comments

This program is great! But it runs very slow when it comes to too many deadlinks. All the threads are just stuck for a very long time. It'll take hours to finish the progress. So, I wonder if we can set a timeout argument, let's say, 10s, would greatly improve the experience!

Karobben avatar Mar 08 '21 15:03 Karobben

Can you describe this feature? Is it timeout for the whole cli? or just for one of the "bad" links?

butuzov avatar Mar 09 '21 01:03 butuzov

Thanks for responding to me. I think an argument for all the links would be cool. The thing was, I ran deadlinks http://localhost:4000/ -n 10 -e -r 2. It worked fine in the beginning. But there were so many deadlinks in my html, I guess. So, it ran slowly when it went to 37%.

I left it running last to another morning, it stuck at 99% and never updated again... It even cannot be ceased by ctrl c

Karobben avatar Mar 11 '21 05:03 Karobben

I got it. Is this a project I also can try (published online or opensource)?

As for the feature, lets added it to to-do list, but just be aware: I have few blockers: time and reppy module, so adding this can take a while... I suggest you watch for releases in this project so you will be notified once feature landed.

butuzov avatar Mar 11 '21 05:03 butuzov

Thanks! I Watched!

Karobben avatar Mar 18 '21 04:03 Karobben