buttplug icon indicating copy to clipboard operation
buttplug copied to clipboard

Buttplug Server should force disconnect if a client doesn't send RequestServerInfo in a specified period of time

Open qdot opened this issue 7 years ago • 3 comments

If a client connects but doesn't send RequestServerInfo, it can jam connections to the server. Set a timer for waiting on RequestServerInfo, and just drop the connection if it isn't sent before the timer expires.

qdot avatar Sep 22 '18 21:09 qdot

Should be done as part of buttplugio/buttplug-csharp#491.

qdot avatar Sep 22 '18 21:09 qdot

Also, it may be worth making a "ServerOptions" object that the server takes as an argument constructor that contains stuff like this, otherwise we're gonna start getting a little wacky with our constructor parameter list.

qdot avatar Sep 22 '18 21:09 qdot

This timeout should be quite a while, at least 30 seconds if not more. We can use the RequestServerInfo handshake wait as a UI trigger in Intiface and other applications so that the user can verify the app requesting access.

qdot avatar Jul 22 '19 05:07 qdot