buttercup-mobile icon indicating copy to clipboard operation
buttercup-mobile copied to clipboard

[WebDAV] Pathing issue: application crash after entering the archive name on android

Open irazers opened this issue 6 years ago • 19 comments

Hi,

When you try to open an archive the android app asks you for an archive name (dunno what this is) and no matter what you do (cancel, ok, empty value, ...) the app crashes.

irazers avatar May 24 '18 08:05 irazers

Please include more detail - it's impossible to discern what's happening with the current info. What version of Android, what phone, etc.. This is the first we've heard of it so it is possible it's an isolated issue. We need to work out, if that is the case, why in your case it's not working.

perry-mitchell avatar May 26 '18 21:05 perry-mitchell

Hi,

I use a oneplus 5 with android 8.1 and my file is on a dropbox account.

The steps to reproduce it are: -add an archive -open dropbox (+log in) -select the file -enter the file password (ok) -enter the file name (crash after hitting ok)

the only feedback I have is android asking me to reopen the app.

irazers avatar May 28 '18 07:05 irazers

I have the same issue on IPHONE. Iphone 7, latest IOS. 11.3.something.

-Add archive using webdav. It connects fine @ https://mynas.mynasprovicer.com:5001/Passwordlocation -Shows folder with DB file. Choose DB file. passwordfile.bcup Archive password: Accepts fine. Archive name: "PasswordDB"

I get this message.

Error: Failed adding archive Failed adding source: Authentication failed - possible tampering

Background:

Migrated from keepass a few weeks ago, and it works generally quite well. - I am able to connect using webdav from chrome from an external location without any problems.

It was working perfectly with my phone for about a week, but for the last 2 weeks I have been getting this message. I have tried removing and adding the DB several times, until I found this message.

Question: Does the archive name determine anything apart from the name on the local device?

Sblop avatar May 28 '18 07:05 Sblop

@Sblop your issue is different, I'm afraid.. most likely #78.

I have tried removing and adding the DB several times

Try editing the archive on desktop and make a small change.. the newly saved archive should work on mobile. This is unfortunately a known issue which we're trying to fix as we speak.

Does the archive name determine anything apart from the name on the local device?

No, nothing apart from how it appears on the device.

perry-mitchell avatar May 29 '18 15:05 perry-mitchell

@irazers Very weird. I'm sorry I don't have any great suggestions right now as this is the first time I've heard of such an issue. By any chance is the file name or archive name weird in any way, or does it contain any characters outside the range a-z0-9_-? Obviously there shouldn't be character encoding issues with characters outside that range, but it's a good place to start.

perry-mitchell avatar May 29 '18 15:05 perry-mitchell

ok so I've tested with a bran new file create with the mobile app and it works perfectly.

Something must come from the archive itself but the archive has no problems with the desktop app

irazers avatar May 29 '18 15:05 irazers

This may be partly related to #78, but I'm not 100% sure. We're in the process of updating the crypto processes in the app to combat issues like that. Hopefully it helps for this issue as well.

perry-mitchell avatar May 30 '18 17:05 perry-mitchell

I might have found something: try to add an archive with subfolders tree in it and it crashes.

irazers avatar Jun 18 '18 07:06 irazers

@irazers Really sorry about the delay on this. I guess you may have moved on, but in case you can remember, were there any special characters in the path? If it's not private, could you possibly share it?

perry-mitchell avatar Aug 03 '18 18:08 perry-mitchell

Hi,

Yes my file is private. I will try to create one from scratch to reproduce the problem

irazer avatar Aug 14 '18 08:08 irazer

@irazer I don't mean your archive, sorry, but the file path. If it's not too secret sharing it might help (if there are spaces or special characters in some order).. It's possible the file path also causes an issue.

Sharing a test archive that fails on your device would also be helpful, of course. Thanks!

perry-mitchell avatar Aug 14 '18 19:08 perry-mitchell

I created a empty library in the same folder and it works fine

A small comment though: there is no possibility to remove an archive from the archive list which is very annoying

irazer avatar Sep 13 '18 08:09 irazer

With the latest version it crashed during/after unlocking the file

irazer avatar Sep 13 '18 08:09 irazer

there is no possibility to remove an archive from the archive list which is very annoying

@irazer There is actually - If you swipe left on a vault in the list, an option to remove it is made visible.

perry-mitchell avatar Sep 13 '18 09:09 perry-mitchell

This file cause the problem

test.zip

irazer avatar Sep 13 '18 09:09 irazer

@irazer I asked earlier but perhaps you misunderstood my request - I was hoping that you might be able to sure the path your archive is stored at. It could be that this is due to the filename you're writing to. If there are folders in your path you would not like to share publicly, please consider contacting me via my keybase account.

perry-mitchell avatar Sep 13 '18 09:09 perry-mitchell

Ok the problem was indeed coming from the path itself it was containing this letter 'é' I changed it and now it works

irazer avatar Sep 13 '18 09:09 irazer

Ok the problem was indeed coming from the path itself it was containing this letter 'é' I changed it and now it works

@irazer That's great! This means we have a clear issue we can address. We'll definitely get this fixed as soon as possible. Thanks for the help!

perry-mitchell avatar Sep 13 '18 09:09 perry-mitchell

Is this still an issue? We've had many updates to the WebDAV library since 2018.

perry-mitchell avatar Jan 26 '20 20:01 perry-mitchell