dbml-parser icon indicating copy to clipboard operation
dbml-parser copied to clipboard

Additions en suggestions

Open JurjenRoels opened this issue 3 years ago • 4 comments

Hello,

nice work. I would like to suggest some changes:

  • instead of keyword ref|Ref I would use ref:|Ref: (This needs some rework probably. table columns starting with ref give an error now)
  • Also use lowercase for tables, projects, etc.
  • 'T_TABLE_SETTING_PK should be primary\skey|pk| (the y is missing)
  • null is not accepted. not null is. The default in ColumnNode is false. This should be true as default when null is not accepted. (See below)
 Syntax error, unexpected "null" (T_NULL)
  43. | identificatieString varchar [unique, null]
      |                                      ^^^^

Maybe I will find more, I will be testing with some dbml's

Good work!

Jurjen Roels

JurjenRoels avatar Apr 04 '22 11:04 JurjenRoels

I updated the description.

JurjenRoels avatar Apr 04 '22 15:04 JurjenRoels

Great work. I am working on a laravel console command, that creates a migration for a dbml file. This depends completely on your parser! We will probably publish that as a separate package.

JurjenRoels avatar Apr 04 '22 16:04 JurjenRoels

Great work. I am working on a laravel console command, that creates a migration for a dbml file. This depends completely on your parser! We will probably publish that as a separate package.

Hi, @JurjenRoels!

I developed this package for "laravel console command, that creates a migration for a dbml file" :D It was my first goal after creating it, but something went wrong and I started working on spiral framework and cycle ORM.

butschster avatar Apr 04 '22 16:04 butschster

Hi Pavel,

if you want to, I can sent you my command once completed, so you can include it in this project?

Regards Jurjen

JurjenRoels avatar Apr 04 '22 17:04 JurjenRoels