busy-beaver
busy-beaver copied to clipboard
Run post_github_summary_message coroutine via RQ
What does this do
- take advantage of new RQ feature to run coroutines on workers processes
- looked thru the code; RQ forks a process and then executes the queued task in the child process so this is a safe change
- run
post_github_summary_message
via RQ
Why are we doing this
Don't have to manually queue up coroutines via asyncio. Results in a cleaner API
How should this be tested
Added pytest-asyncio to make it easier to test coroutines
Migrations
n/a
Dependencies
n/a
Callouts
n/a
Codecov Report
Merging #359 (b7e231f) into master (5e3543f) will decrease coverage by
0.13%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## master #359 +/- ##
==========================================
- Coverage 89.51% 89.38% -0.14%
==========================================
Files 71 71
Lines 2509 2506 -3
==========================================
- Hits 2246 2240 -6
- Misses 263 266 +3
Impacted Files | Coverage Δ | |
---|---|---|
busy_beaver/apps/debug/workflows.py | 0.00% <0.00%> (ø) |
|
...beaver/apps/github_integration/summary/workflow.py | 95.45% <100.00%> (ø) |
|
busy_beaver/common/wrappers/github.py | 97.08% <100.00%> (-0.17%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5e3543f...b7e231f. Read the comment docs.