gulp-rev-append icon indicating copy to clipboard operation
gulp-rev-append copied to clipboard

basePath & regExp now can be configured

Open StyleT opened this issue 9 years ago • 3 comments

Now user can specify base path or regular expression

StyleT avatar Jul 12 '15 20:07 StyleT

Anyone is here?

StyleT avatar Jul 24 '15 05:07 StyleT

@StyleT

I appreciate your interest and this PR.

I am currently deciding on the relevance of its improvement for the following reasons:

  1. Would not overriding a basePath to a file essentially mean that you can possibly point it to any file, therefore giving it false-y file hash?
  2. Providing a custom regex would A) cause more developers (and opened issues) having problems with their own faulty regex thinking it is gulp-rev-append issue and B) be better suited for a tool such as gulp-replace

Truthfully, it's Number 2 that really is keeping me from accepting this PR (along with no additional test to ensure that the changes do what they propose). I use gulp-replace quite often and I think it would be a better tool in what this PR may be trying to accomplish.


I do appreciate your work and would like to hear your thoughts to make me change my mind.

I also apologize for the late response; life happens :)

bustardcelly avatar Dec 18 '15 04:12 bustardcelly

+1 for the PR! I need it because I am moving the html from the src to the dist folder, and in src there are not the compiled files to which the html refers (I am using typescript and stylus).

pasqLisena avatar May 03 '16 16:05 pasqLisena