Olga Kopylova

Results 19 comments of Olga Kopylova

Meeting minutes: * Vadim Justus: provision entity data, it is not the one time scenario. Sometimes new requirements come from 3rd-party systems, so data should be updated/added. * Stepan: Config...

@fascinosum : How events on configuration update will be covered? May be not an issue for initial installation, but may lead to unexpected behavior during update.

Regarding required attributes: agreed that as this is an existing problem, it's not necessarily should be addressed in this proposal. A default value should be used for attributes whenever possible,...

What do we do with EAV attributes - they are snake case? * Convert them for consistency

+1. It will also help to run phpmd tests on Travis CI. Now Travis just stops the build after 10 min of waiting :(

When implementing, please remove a [static test](https://github.com/magento/magento2/blob/2.3-develop/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php#L345) that cover the same thing.

My 2 cents: 1. Restrictions specific to Magento version (not PHP version) should not be hard-coded in the rules themselves. Like a business logic. Today we may want to apply...

Looks like, first we should update our guidelines with the rules around objects instantiations with reasoning. And the the cs rule should cover it by the automation.

Please see https://github.com/magento/devdocs/pull/3982/files Let's have a discussion what we want as a rule. It should have good balance of value/overhead.