simavr
simavr copied to clipboard
buserror
examples/* doesn't create ${OBJ} directory automatically
The directory "obj-x86_64-linux-gnu" needs to be manually created to get the examples to compile. Without it, I get this error (for i2ctest for example):
i2ctest.c:87:1: fatal error: opening dependency file obj-x86_64-linux-gnu/i2ctest.d: No such file or directory
Clearly not a big deal but it's annoying if someone new wants to just run them, and it's a nuance of compiling to find it and fix it.
The directories don't ship since .gitignore has obj-*, and everything else is handled in the simavr/simavr/Makefile which creates the obj- directory on line 137:
mkdir -p ${OBJ} ; echo >${OBJ}/cores.deps ; echo >$(DEBUGLOG) ;\
Each example Makefile has
all: obj ...
where obj is defined in Makefile.common, and I think correctly, but I'm not clear why it's not inheriting.
In Makefile.common I changed
obj: ${OBJ}
to
obj: ${E}mkdir -p ${OBJ}
which just mimics the ${OBJ} target. seems to do the trick. Again im not sure why using the ${OBJ} target in obj: ${OBJ} does not work.
$ make works at each level.
Tested on debian 9, i dont have a mac to test on.
I have the PR ready if interested but I'm not permissioned on the repo.
Again im not sure why using the ${OBJ} target in obj: ${OBJ} does not work.
It is because of VPATH += ../parts that is found in the Makefile of the examples (I stumbled upon this today with simavr/examples/board_simduino/Makefile) and got really annoyed of this behavior as well. AFAICT, the parts/obj-x86_64-linux-gnu exists and makes the simavr/examples/board_simduino/Makefile think it does not need to create obj-x86_64-linux-gnu in the current folder.
Reading http://make.mad-scientist.net/papers/rules-of-makefiles/#rule3 and http://make.mad-scientist.net/papers/how-not-to-use-vpath/ suggests that the use case for VPATH in simavr Makefile seems to be not proper causing this kind of behavior.
Well VPATH works file, we just need to add a few 'optional targets' wiht | (pipe) to add the OBJ dependencies to some of the rules. I'll have to revisit that.
