simavr icon indicating copy to clipboard operation
simavr copied to clipboard

Improve pty support

Open marvin2k opened this issue 8 years ago • 4 comments

Hey,

have a look at the following code. Allows using the "simduinio" pty-interface selectively for a given number of uarts. Carefull, this PR changes the meaning of "SIMAVR_UART_XTERM" envvar....

So this might not be merged as-is, but anyways: I found the adoptions highly useful while debugging code involving a multi-uart-device talking to the external world.

Suggested follow-on commits: Remove "uart_udp.{c,h}", adopt "simduino" to use the symbols of "uart_pty" from libsimavr.

Greetings

marvin2k avatar Oct 28 '15 16:10 marvin2k

Well, I might cherry pick a few bits from here, but I have made separately a command line shell of sort for simavr, and I'd like to merge that at some point to 'upgrade' run_avr, so I'll keep the PR open and will refer to it when I eventually do that...

buserror avatar Nov 07 '16 08:11 buserror

Hi @buserror. Is the mentioned shell available anywhere? I'm looking for a similar serial PTY option to what is provided here, and wondering if polishing up this PR would make it an solution acceptable for merging. Or if I should just have my own fork of simduino..

I also think that PTY support in run_avr itself would solve #157 and #182

jonnor avatar Mar 16 '17 20:03 jonnor

I'm not keen on adding too much to run_avr itself to be honest...

Yes I do have a separate shell that I'm planning to merge pretty soon -- in fact as soon as my rf_birdge project is 'done' I'll create a new branch with it. I'd like to supersede the simduino with it, but also have it as a more generic way to interact with firmwares.

The 'shell' has easy access to set the ADC values, inspect and change ELF symbols/variables on the fly etc. It's pretty cool and easy to extend.

buserror avatar Mar 17 '17 08:03 buserror

It would be great to have this merged already...

phd avatar Mar 24 '19 11:03 phd

I've tested this branch and it's impressive how easy it is to get a pty linked to uart. After many hours trying to make this link works, I'm surprised to see that this branch is just perfect for that. So ye would be really great to see it merged..

Theiremi avatar Feb 08 '23 13:02 Theiremi

@buserror Was this code merged elsewhere, or other code provide similar functionality? Or was it closed as a wont-fix?

jonnor avatar Aug 11 '23 19:08 jonnor