terminus icon indicating copy to clipboard operation
terminus copied to clipboard
verified publisher icon bus-stop

xterm

Open UziTech opened this issue 5 years ago • 3 comments

replaces term.js with xterm

fixes #211 fixes #210

Tests:

  • [ ] Open terminal
  • [ ] Resize terminal
  • [ ] Move terminal to dock
  • [ ] Resize dock
  • [ ] Type in terminal
  • [ ] Test different options

UziTech avatar Mar 24 '21 17:03 UziTech

Tests

  • [x] Open terminal
  1. Open terminal via taskbar
  2. Terminal opens without signs of life
  3. Toggle terminal via shortcut
  4. Terminal opens and closes until it gets stuck and wont be closed

  • [x] Resize terminal Terminals cant be resized

  • [x] Move terminal to dock Terminal cant be dragged

generic

generic

and aborted tests.

Atom    : 1.55.0
Electron: 6.1.12
Chrome  : 76.0.3809.146
Node    : 12.4.0

apm  2.5.2
npm  6.14.8
node 12.4.0 x64
atom 1.55.0
python 2.7.17
git 2.30.1.windows.1
visual studio

Windows 10 Workstation 1909

the-j0k3r avatar Mar 25 '21 10:03 the-j0k3r

Had a couple of minutes to retest this under Ubuntu + Atom 1.57.0, similar result as initial test.

It may be worth noting that the lockfile version is being modified on install and this has a considerable diff.

See https://gist.github.com/the-j0k3r/f8291565d36b37cef33d32ef1b5961ff/revisions

No sure how that would affect the installation or if it is the cause for issues.

@UziTech with :heartbeat:

the-j0k3r avatar Jun 11 '21 12:06 the-j0k3r

I think this just needs to use the xterm-fit-addon to be able to resize correctly. I will have more time in about a week to try to finish this.

UziTech avatar Jun 13 '21 15:06 UziTech