Termination icon indicating copy to clipboard operation
Termination copied to clipboard

Highlight selected text

Open levblanc opened this issue 7 years ago • 5 comments

Atom: 1.16.0 Termination: 0.5.1 OS: MacOS 10.11.6

When I tried to select some text to copy, the selected part was not highlighted.

The select and copy functions actually worked fine, so I think this is just a tiny visualization problem. :)

levblanc avatar May 04 '17 03:05 levblanc

Hi @levblanc and thanks for trying Termination!

Sorry about that. Can you maybe take a screenshot? I don't have a mac and I can't reproduce this on my Linux and Windows machines. Are you using any particular theme? Does the highlighting work if you use another theme?

Thanks! Fred

Fred-Barclay avatar May 04 '17 03:05 Fred-Barclay

@Fred-Barclay Thanks for your reply.

After taking a screenshot, I saw the highlight in it. That becomes a problem of my external monitor then. Haha.

Talking about theme, I think the theme setting part should clarify that changing takes effect only on new terminals. I thought it would take instant effect and was waiting for your next versions to fix it, until I changed to a white background theme, then restart my editor and found my theme settings suddenly worked. Surprised!

levblanc avatar May 04 '17 07:05 levblanc

Whew - I was a bit worried as I don't have a mac, and if this were mac-specific it could have been difficult to fix. 😄

Talking about theme, I think the theme setting part should clarify that changing takes effect only on new terminals.

That's a good idea. I'll add something like "Changing themes requires a terminal restart" or something like that.

Take care, Fred

Fred-Barclay avatar May 04 '17 14:05 Fred-Barclay

@Fred-Barclay

Actually, it would be better if you could make the highlight in a lighter color. :)

highlight in Termination: image

highlight in Hyper: image

levblanc avatar May 08 '17 02:05 levblanc

Yeah, that sounds like something we need to look at. Thanks!

Fred-Barclay avatar May 08 '17 04:05 Fred-Barclay