garble icon indicating copy to clipboard operation
garble copied to clipboard

correctly detect indirect uses of reflection

Open lu4p opened this issue 3 years ago • 3 comments

(see commit message)

lu4p avatar Jun 21 '22 02:06 lu4p

@mvdan added some docs and support for composite literals

lu4p avatar Jun 21 '22 17:06 lu4p

Before I do another round of review - did you benchmark this? I generally assume that bug fixes come before performance, but this go/ast analysis is adding two more ast.Inspect calls and one is nested, so I'm somewhat worried that this will negatively affect build times.

mvdan avatar Jun 23 '22 14:06 mvdan

Another reason for (slight) worry is that you seem to be tracking most forms of assignments via either foo = bar or foo: bar, so that will likely be quite a lot more book-keeping for code being obfuscated.

mvdan avatar Jun 23 '22 14:06 mvdan