tensorflow-101 icon indicating copy to clipboard operation
tensorflow-101 copied to clipboard

Performance issue in /finetuning/convert_pys (by P3)

Open DLPerf opened this issue 2 years ago • 1 comments

Hello! I've found a performance issue in /finetuning/convert_pys/covert_datasets_tfrecord.py: with tf.Session('') as sess(here) is defined in the function _convert_dataset(here) which is repeatedly called in the loop for i in range(nFold)(here).

tf.Session being defined repeatedly could lead to incremental overhead. If you define tf.Session out of the loop and pass tf.Session as a parameter to the loop, your program would be much more efficient. Here is the Stack Overflow post to support it.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf avatar Aug 25 '21 08:08 DLPerf

Hello, I'm looking forward to your reply~

DLPerf avatar Nov 04 '21 09:11 DLPerf