Anton Burnashev
Anton Burnashev
Hi @23rdPro, thank you again for your thoughtful contribution and follow-ups. I really appreciate the time and effort you put into creating the notebook demo. After careful consideration, the team...
Hey @francescomucio could you share a use case for having the path interpolated from param value? ```py ... "endpoint": { "path": "users/{id}", "params": { "id": 2, }, }, ... ```
Thanks for elaborating @francescomucio I believe the similar case has just been reported in the community Slack: https://dlthub-community.slack.com/archives/C04DQA7JJN6/p1719291805818969 I'm thinking how to put this together with the current rest_api config....
@francescomucio I'm unable to reproduce it now with the reqres.in example above: ``` 2025-02-18 10:19:15,978|[INFO]|26403|8365117248|dlt|client.py|_send_request:124|Making GET request to https://reqres.in/api/users/2 with params={}, json=None ``` Most likely this has been fixed already....
Valid point. > Centralize everything under dlt.sources.rest_api module. It makes more sense to keep this one since it's the required import and the other contains helpers. I have a different...
I propose an alternative solution to logging the full HTTP response on error: we can use a context manager `catch_http_error` that captures HTTP errors and allows for flexible and controlled...
Hey @willi-mueller, thanks so much for this PR! I'm going to close it for now: initially I suggested and took a different approach here, but after consideration, I've decided to...
Hi @davidcotton, thanks so much for offering to help. I'm planning to put together a draft version of this source soon and would be very grateful if you could give...
Hi @rakesh-tmdc, thanks for the contribution, this looks good and useful. In [dlt+](https://dlthub.com/docs/plus/intro) we already have an [`iceberg_adapter()`](https://dlthub.com/docs/plus/ecosystem/iceberg#using-the-iceberg_adapter-function) with `iceberg_partition` helpers for these transforms. We're open to moving this adapter...
Hi @rakesh-tmdc, I've ported the `iceberg_adapter()` and `iceberg_partition` helpers from dlt+ to dlt core. These are now available in `dlt/destinations/impl/filesystem/iceberg_adapter.py` and provide the canonical way in dlt to configure Iceberg...