python-readability icon indicating copy to clipboard operation
python-readability copied to clipboard

Eliminate display:none tags

Open arski opened this issue 12 years ago • 1 comments

Hi there, I have a request that shouldn't be too hard to make, though might require some trickery for a proper full CSS solution.

If you look at the code of http://www.readwriteweb.com/start/2012/04/what-do-angels-want.php you'll see some tags like <div style="display:none;" id="disqus_post_message">...</div> in there, which are clearly hidden and shouldn't come up in the summary. However, in the current version of the library they do (and the display:none is stripped out in the summary()).

Interestingly, in the bookmark version of readability, these things don't show up, not even as display:none, so maybe there is a fix there already?

Thanks so much for looking into it.

Cheers

arski avatar Apr 13 '12 18:04 arski

Determining tags visibility is out of scope for this project. It's much easier in bookmark version -- it has DOM with css and javascript applied.

But check for style="display:none" can be handled if anyone else but me will implement this. I'm in "maintainer mode" now, so don't have time to implement new functionality. Sorry.

buriy avatar Apr 14 '12 19:04 buriy