react-transliterate
react-transliterate copied to clipboard
Cannot type comma (,) gets deleted automatically
Typed ram,
clicked space
Actual - the comma got lost, Expected/Suggestion - show comma in the suggestion aswell
@burhanuday , just want to check are you still managing this repo as I don't see any updates in this repo recently.
@Santosh-13 Here's probably what's going on. I take the last word typed by the user by splitting the sentence by the space characters. ram,
is getting picked as the last word. so far so good
then ram,
gets sent to the Google transliteration API which is removing the punctuation in the result. Can you open a PR that fixes this logic?
the expected way should be that if its a punctuation at the end, it should be removed from being sent to the api and then get readded to the result
temporary workaround is to select option first and then add the punctuation
@Santosh-13 Here's probably what's going on. I take the last word typed by the user by splitting the sentence by the space characters.
ram,
is getting picked as the last word. so far so good thenram,
gets sent to the Google transliteration API which is removing the punctuation in the result. Can you open a PR that fixes this logic?the expected way should be that if its a punctuation at the end, it should be removed from being sent to the api and then get readded to the result
temporary workaround is to select option first and then add the punctuation
looks like i dont have write access on this repo, can you provide it
@Santosh-13 please fork the repo and send a pull request
@burhanuday , please take a look at this PR - https://github.com/burhanuday/react-transliterate/pull/52
@burhanuday , please take a look at this PR - https://github.com/burhanuday/react-transliterate/pull/52
@burhanuday , please take a look at this PR - https://github.com/burhanuday/react-transliterate/pull/52 for this issue fix