Lukas Burgholzer

Results 230 comments of Lukas Burgholzer

#996 and #1010 have been merged and lay the foundation for this; specifically, there is now a QDMI device for a neutral atom platform as well as a QDMI driver....

This is probably blocked by #429, right?

> > This is probably blocked by #429, right? > > Not necessarily. The main problem is that in Qiskit v2.0, `transpile` does not accept the `basis_gates` argument with custom...

I don't have a particular preference here. Some kind of unification definitely makes sense. I am also fine with breaking changes here as long as they lead to an improvement...

> Regarding the boilerplate code: You're right and I already thought about that. Unfortunately, a utility function wouldn't work that easily. We use FileSplit to split the test file into...

> Thanks for the questions/suggestions @burgholzer and @DRovara! > > > * Is the explicit return statement in all these tests necessary? It kind of seems wasteful. > > Regarding...

> > * they typically collect all the check statements and do not interleave them with the actual code. That kind of looks nicer to me. Any opinions on that?...

> I've grouped the check statements similarly to how they are presented in the testing guide. Please let me know if there are any necessary changes left! Thanks 🙏🏼 I...

> [@burgholzer](https://github.com/burgholzer) Could you please assign this to me. The PR is [#991](https://github.com/munich-quantum-toolkit/core/pull/991) I'll assign you once the Pull Request has been merged.

@jannikpflieger any updates on this? it's been three weeks since the review above 😌