Lukas Burgholzer

Results 77 comments of Lukas Burgholzer

Please resolve the conflicts reported by git and check that CI passes on your changes. Otherwise, I can't give this a proper review.

Please consider extending the C++ tests to cover your changes and assert that everything works properly.

> Qiskit provides custom gate definitions just as in the example above for any gate that is not in `qelib1` (and any general QASM parser should be able to read...

Awesome! Many thanks. I'll surely check this out soon 👍🏻

Thanks for the feature request. It should certainly be possible to get that working. I'll get back to you on that 👍🏻

> Please show me ONE python module which depends on some cmake features added after first cmake 3.0. > I have already packaged as rpm packages A little more than...

> Why do you want to use `FetchContent` if cmake already is installed in the system image? 🤔 We do not use FetchContent to get CMake, but other project dependencies....

> Name of those modules. None of those six modules which I've mentioned so far which are using cmake are using `FetchContent`. For example, `googletest` or `nlohmann_josn` to name the...

> https://pypi.org/project/gtest/ is no longer maintained. Homepage shows 404. > > https://github.com/nlohmann/json/ it is not python module. Yeah. And I never claimed that. These are dependencies of our C++ code...