catchr and rlang 1.0.0

[lionel-]

Hello,

I'm seeing several errors with dev rlang. We plan to release it in 2 to 4 weeks. With R CMD check I see these two:

check_and_clean_input(d1 = base::acosh, spec_names = "acosh")
#> Error in `call_name()`: `call` must be a simple call.
#> ℹ Calls to `::` or `:::` are not simple calls.
#> ℹ See `?is_call_simple`.


opts <- catchr_opts(
  default_plan = c(collect, muffle),
  drop_empty_conds = FALSE,
  bare_if_possible = FALSE
)
plans <- make_plans(warning, message, error, .opts = opts)

res <- catch_expr(condition_thrower(), plans)
res2 <- catch_expr(dispense_collected(res), plans)
waldo::compare(res, res2)
#> `old$error[[1]]` is length 2
#> `new$error[[1]]` is length 3
#>
#> `names(old$error[[1]])`: "message" "call"
#> `names(new$error[[1]])`: "message" "call" "trace"
#>
#> `old$error[[1]]$trace` is absent
#> `new$error[[1]]$trace` is an S3 object of class <rlang_trace/rlib_trace/tbl/data.frame>, a list

The call_name() error is a planned breakage, it now needs to be paired with is_call_simple().

I see more issues with interactive devtools::test() but haven't investigated. Could you take a look and let me know if you think there is any bug in rlang that causes failures please?