bupaR icon indicating copy to clipboard operation
bupaR copied to clipboard

Reverse dependency issue related to how `fill()` is re-exported

Open DavisVaughan opened this issue 4 weeks ago • 0 comments

Hi, I see you reexport fill() from tidyr here and also add your own method:

https://github.com/bupaverse/bupaR/blob/c9b9eed4705f4e7a42d6ff378227f5615fa44150/R/fill.R#L1-L8

Unfortunately the way you re-export is incorrect:

#' @title Fill event log
#' @param data \code{\link{log}}: Object of class \code{\link{eventlog}} or \code{\link{activitylog}}.
#' @param ... Additional arguments passed to [tidyr][fill]
#' @inheritParams tidyr::fill
#' @name fill
#' @importFrom tidyr fill
#' @export
tidyr::fill

We have added a new .by argument to fill() in dev tidyr, and this causes your package to fail with:

Package: bupaR
Check: for code/documentation mismatches
New result: WARNING
  Codoc mismatches from Rd file 'fill.Rd':
  fill
    Code: function(data, ..., .by = NULL, .direction = c("down", "up",
                   "downup", "updown"))
    Docs: function(data, ..., .direction = c("down", "up", "downup",
                   "updown"))
    Argument names in code not in docs:
      .by
    Mismatches in argument names:
      Position: 3 Code: .by Docs: .direction

If you could please reduce this reexport down to the following, then it should work regardless of how we change fill()

#' @importFrom tidyr fille
#' @export
tidyr::fill

We are currently releasing tidyr, so you will likely get a note from CRAN about this soon.

DavisVaughan avatar Dec 18 '25 18:12 DavisVaughan