homebrew-cask-upgrade icon indicating copy to clipboard operation
homebrew-cask-upgrade copied to clipboard

Add batched update option for interactive mode

Open XOR-op opened this issue 3 years ago • 2 comments

This PR add support for batched update option for interactive mode.

To be specific, I add option b for each interaction. And for each app answered with b, I record it in a temporary list, then perform upgrade after all interactions are answered.

Fixes https://github.com/buo/homebrew-cask-upgrade/issues/182 (asks for the same feature enhancement)

XOR-op avatar Feb 13 '22 04:02 XOR-op

Thank you for your contribution @XOR-op 🙂 I was just wondering, why you went this path? My idea was to not have yet another option but change slightly the way it works - you would add it to the batch when "y" was given and then do the upgrades. Do you think it makes sense? Could you make that change?

ondrejfuhrer avatar Feb 24 '22 17:02 ondrejfuhrer

Thank you for your contribution @XOR-op 🙂 I was just wondering, why you went this path? My idea was to not have yet another option but change slightly the way it works - you would add it to the batch when "y" was given and then do the upgrades. Do you think it makes sense? Could you make that change?

You're right. However I have no experience in Ruby, so I'm not sure if I would break something in that manner. Also I've pushed a new commit to recover original flag.

XOR-op avatar Apr 27 '22 07:04 XOR-op

Hey @XOR-op , I've come up with an alternative, where I first asks for the input and then execute it. Feel free to look into the solution or propose any changes (https://github.com/buo/homebrew-cask-upgrade/pull/224).

ondrejfuhrer avatar Dec 25 '22 20:12 ondrejfuhrer

Closed in favour of #224

ondrejfuhrer avatar Dec 26 '22 21:12 ondrejfuhrer