scala-js-snabbdom

scala-js-snabbdom copied to clipboard

According to https://github.com/snabbdom/snabbdom/pull/1019 it's not a bug? So then seems something is broken here. https://github.com/buntec/scala-js-snabbdom/blob/4c064dbff3d96970e0062f06e539a67c8e1d2898/snabbdom/src/test/scala/snabbdom/SnabbdomSuite.scala#L430-L438 We may want to target a patch at an 0.1.1 release.

armanbilge

Update to match snabbdom 3.5.0

1

Not really sure what I'm doing, so please review carefully :)

armanbilge

Goal of this project 🚀

5

This project is great, I am super happy to see this port (also because I wanted to do so since a long time). Potentially, it might also be very useful...

cornerman

This has manifested in a couple ways so far: 1. varargs vs explicit collections, see: https://github.com/PurpleKingdomGames/tyrian/pull/99#discussion_r866990656 2. `Any` for attributes vs `Option[String]`, see: https://github.com/buntec/scala-js-snabbdom/pull/16#discussion_r867363239

armanbilge

Make as much as possible `private`, `final`, and `sealed` to make it easier to evolve the API binary-compatibly. For the record, it remains an open question how important binary-compatibility will...

armanbilge

This is a nice-to-have, but I think it could be interesting. Unlike the original snabbdom.js, scala-js-snabbdom is amenable to GCC's advanced optimizations. So, at least in theory, this port could...

armanbilge

## About this PR 📦 Updates [org.scalameta:munit](https://github.com/scalameta/munit) from `1.0.0-M11` to `1.0.1` 📜 [GitHub Release Notes](https://github.com/scalameta/munit/releases/tag/v1.0.1) - [Version Diff](https://github.com/scalameta/munit/compare/v1.0.0-M11...v1.0.1) ## Usage ✅ **Please merge!** I'll automatically update this PR to resolve...

scala-steward

Update scalafmt-core to 3.8.3

2

## About this PR 📦 Updates [org.scalameta:scalafmt-core](https://github.com/scalameta/scalafmt) from `3.7.17` to `3.8.3` 📜 [GitHub Release Notes](https://github.com/scalameta/scalafmt/releases/tag/v3.8.3) - [Version Diff](https://github.com/scalameta/scalafmt/compare/v3.7.17...v3.8.3) ## Usage ✅ **Please merge!** I'll automatically update this PR to resolve...

scala-steward

Update sbt-typelevel to 0.7.2

2

## About this PR 📦 Updates [org.typelevel:sbt-typelevel](https://github.com/typelevel/sbt-typelevel) from `0.4.11` to `0.7.2` 📜 [GitHub Release Notes](https://github.com/typelevel/sbt-typelevel/releases/tag/v0.7.2) - [Version Diff](https://github.com/typelevel/sbt-typelevel/compare/v0.4.11...v0.7.2) ## Usage ✅ **Please merge!** I'll automatically update this PR to resolve...

scala-steward

Bump jsdom from 24.0.0 to 24.1.1

3

Bumps [jsdom](https://github.com/jsdom/jsdom) from 24.0.0 to 24.1.1. Release notes Sourced from jsdom's releases. Version 24.1.1 Fixed selection methods to trigger the selectionchange event on the Document object. (piotr-oles) Version 24.1.0 Added...

dependabot[bot]