sdk_csharp icon indicating copy to clipboard operation
sdk_csharp copied to clipboard

Published 20 hours ago • verified publisher icon bunq

Constants following PascalCase convention

Open kid-cavaquinho opened this issue 7 years ago • 8 comments

This PR closes/fixes the following issues:

  • Closes bunq/sdk_csharp/issues/58 (And what a struggle with that commit regex 🙃)
    • [x] Tested

kid-cavaquinho avatar Dec 27 '17 16:12 kid-cavaquinho

@antao 😁 Nice on getting the commits right!

And thanks for this pull request!

OGKevin avatar Dec 27 '17 17:12 OGKevin

@sandervdo you're up, please 👀

OGKevin avatar Dec 28 '17 10:12 OGKevin

Total tests: 36. Passed: 36. Failed: 0. Skipped: 0.

All tests are passing. 👏.

Because this PR doenst need any extra tests, I'm marking the Tested task as done.

OGKevin avatar Dec 28 '17 10:12 OGKevin

@antao FYI I've pushed some minor changed, be sure to pull before you push new changes 👍

OGKevin avatar Dec 28 '17 20:12 OGKevin

Thanks for the push @OGKevin

kid-cavaquinho avatar Dec 29 '17 07:12 kid-cavaquinho

@antao I dont understand ? Why did you close this pull request ? There is nothing wrong with it!

OGKevin avatar Dec 29 '17 07:12 OGKevin

@OGKevin I did not even noticed I've closed it. My bad! Thanks for re-opening it.

kid-cavaquinho avatar Dec 29 '17 07:12 kid-cavaquinho