Aapo Talvensaari

Results 278 comments of Aapo Talvensaari

@lordnynex, great, but I think you pointed me to one obvious flaw (not related to your issue). Have you checked the latest master, and if yes, does it cause any...

yes, good catch, I think they are sharing the same cache key. This needs to be fixed somehow.

Yes, it should. Have to figure out what would be a better way to auto generate cache key without affecting too much cache access times.

@craveica In general I think it is an issue with globals. I think we just need to add support for `template.new(opts)` which return object similar to `require "resty.template"` but so...

oh I have missed that, let me check it, and thank you for reporting.

@xiangnanscu, does it work if you change: https://github.com/bungle/lua-resty-template/blob/master/lib/resty/template.lua#L302 ```lua context.view = function(ctx) return template.process(view, ctx or context) end ``` to: ```lua context.view = template.process(view, context) ``` I still need to...

@xiangnanscu, yes, that sounds like a better option. Let me take a look.

@decadence, great feedback! that nice! let me see if I can do something about it.

you could also use something like gettext, and perhaps generate language templates with it. Then on runtime load language specific template.

I have even created LuaJIT FFI bindings to it: https://github.com/bungle/lua-resty-gettext/blob/master/lib/resty/gettext.lua