deutschland icon indicating copy to clipboard operation
deutschland copied to clipboard

refactor: refactor bundesanzeiger module and config to work concurect…

Open FelixBehne opened this issue 1 year ago • 3 comments

Hey, while using the Bundesanzeiger module, I noticed some issues that I want to fix with this pull request for everyone.

  • I introduced concurrency to improve the script's performance by up to 300%. This should make it faster and more efficient when searching for reports.
  • I added a progress bar and more user feedback to make the module less opaque and more user-friendly. You'll now have a better understanding of what's happening behind the scenes.
  • I optimized the overall code quality and documentation to make it easier to read and maintain.
  • Additionally, I've included new functions to extract interesting data from reports and visualize them. While these functions may not work for every company, I believe they will be useful for many users.

I hope you find these improvements helpful and valuable. Thank you for considering this pull request ;)

FelixBehne avatar Apr 16 '23 21:04 FelixBehne

Hi,

Thanks so much for your contribution. Great work 👏

I need some time for a deeper look. But from what I can tell from a quick look you used type hints which require python 3.10. (e.g dict)

We should keep the min python version the same if possible.

wirthual avatar Apr 17 '23 04:04 wirthual

HI @FelixBehne ,

Would you mind merging back main into your branch? I guess the import order changed due to isort.

wirthual avatar May 25 '23 20:05 wirthual

Hi @FelixBehne ,

I merged back the current master. I included the changes for raw_report which was added in the meantime. Also I changed the code to be compatible with Python 3.8.

Would you mind looking over the merged changes if you see any problems due to the merge?

I would really appreciate it.

wirthual avatar Jul 06 '23 22:07 wirthual