stud icon indicating copy to clipboard operation
stud copied to clipboard

Published 20 hours ago • verified publisher icon bumptech

SSL error queue fix

Open dowski opened this issue 12 years ago • 2 comments

Errors were not getting cleared from the queue between various OpenSSL function calls. This was causing the error queue to contain misleading information on subsequent calls to SSL_get_error.

One degenerate case was incorrect dispatching of errors after a failed SSL_read. Conditions that simply should have lead to another call to SSL_read were being treated as fatal. This was verified while stracing a stud process and seeing read() return with EAGAIN and stud immediately closing the socket fd and logging an SSL_read error.

dowski avatar Jan 02 '13 18:01 dowski

I think I've been bitten by this bug. Is there a problem with the patch?

#100 is related.

edevil avatar Mar 06 '13 09:03 edevil

The patch is good. It's been running in production for a few months now and has solved the problem reported in the description.

dowski avatar Mar 09 '13 05:03 dowski