Per product taxRate

[joshuadegier]

Hey,

good work on the repo! Only just found this after forking the original repo myself and updating it to work with Laravel 5.8. I've currently also modified the package to be able to set per-product taxRates (which defaults back to config('cart.tax') in case there is non set. Only breaking change would be the Buyable interface which now requires a getBuyableTaxRate() method.

Seems a bit useless for me to have this in a separate repo if you feel like having this feature in this package as well. Feels better to bundle the powers :-)

Changes can be found here: https://github.com/PendoNL/LaravelShoppingcart

Let me know if this sounds interesting.

[bumbummen99]

Hey, sorry for the late response, real life is kind of stressfully currently. If you would like to create a pull request i will take a look on it and check if we can improve the current solution in this repository.

[joshuadegier]

Hi, no problem. I get it :-)

My repo is based on the original, so I don't think I can easily do a PR right now. I remember I didn't need to do too many changes to get this working. As said, it will be a breaking change since the Buyable interface requires the model to have a getBuyableTaxRate() method.

I can spend some time on making a PR, but only if the idea seems useful of course.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days