svg-pan-zoom icon indicating copy to clipboard operation
svg-pan-zoom copied to clipboard

Add rotate options in javascript

Open bastienmoulia opened this issue 9 years ago • 8 comments

https://docs.npmjs.com/files/package.json#license

bastienmoulia avatar Nov 26 '15 11:11 bastienmoulia

I had to disable the header banner in gulp because it crash.

bastienmoulia avatar Nov 30 '15 16:11 bastienmoulia

Great work @bastienmoulia ! You didn't have to commit dist files, but this is easy to fix. It will be great to add tests and demos. Without demos it will be hard for other users to understand how it works.

I'll take a look other this commit in more detail over next days.

@ariutta can you please confirm that that's the right version of BSD license? The complete list is here.

Thanks!

bumbu avatar Dec 06 '15 21:12 bumbu

Had the same header issue and made a fix in #178 . I don't know exactly how this will merge.

jeremyVignelles avatar Dec 21 '15 11:12 jeremyVignelles

@bumbu since this PR is almost 1 year old, should we keep it open?

Yimiprod avatar Jan 09 '17 16:01 Yimiprod

If this fonction is needed i can make a new PR with an updated version.

bastienmoulia avatar Jan 09 '17 17:01 bastienmoulia

@bastienmoulia and @bumbu, I apologize for the delay here. I'm sorry that I don't really have the bandwidth to properly review pull requests for new features right now.

@Yimiprod, I invited you to be a collaborator. You and any of the other collaborators can feel free to manage issues and pull requests, using your best judgment.

@aleofreddi, you originally specified a BSD license. Is BSD-2-Clause correct?

ariutta avatar Oct 29 '19 17:10 ariutta

Hi,

As a big time user of this extension in angular is there any view on when this will be merged?

Can I merge these files locally myself?

Br,

Tom

shadowjustice avatar Jan 21 '20 15:01 shadowjustice

Hi i finally got my fork running by upgrading to gulp v 4 (node 12 +) I tested this pull request and it works!

EDIT: Since this pull request is so old I will try based on this one to make a new one with the rotate option. (which do not have conflicts)

shadowjustice avatar Feb 04 '20 20:02 shadowjustice