bulwark icon indicating copy to clipboard operation
bulwark copied to clipboard

Permission checks should use BTreeSet instead of Vec

Open coderabbitai[bot] opened this issue 2 years ago • 1 comments

This issue tracks the suggested improvement to replace with for storing allowed HTTP domains and remote state key prefixes in and functions. This change aims to enhance performance by enabling faster lookups and more efficient permission checks.

Related PR: https://github.com/bulwark-security/bulwark/pull/202 Comment: https://github.com/bulwark-security/bulwark/pull/202#discussion_r1516967044

coderabbitai[bot] avatar Mar 11 '24 23:03 coderabbitai[bot]

The verify_http_domains and verify_remote_state_prefixes functions should take a BTreeSet<String> parameter instead.

sporkmonger avatar Mar 12 '24 00:03 sporkmonger