novo-elements icon indicating copy to clipboard operation
novo-elements copied to clipboard

fix: making render constructor properties public so it can be extended

Open dvoegelin opened this issue 2 years ago • 0 comments

Description

novo and novo-elements have nearly identical RenderPipe components. they have diverged slightly since written, since any changes in one would have to be made in the other, and that hasn't always happened. also the novo-elements version uses a clone of the the EntityUtil.getEntityLabel() function which is also out of date. this PR is going to try to combine them as best as possible so that the novo RenderPipe can extend the novo-elements RenderPipe with as little duplicated code as possible.

Verify that...

  • [ ] Any related demos were added and npm start and npm run build still works
  • [ ] New demos work in Safari, Chrome and Firefox
  • [ ] npm run lint passes
  • [ ] npm test passes and code coverage is increased
  • [ ] npm run build still works

Bullhorn Internal Developers

  • [ ] Run Novo Automation
Screenshots

dvoegelin avatar Apr 27 '22 16:04 dvoegelin