showcase icon indicating copy to clipboard operation
showcase copied to clipboard

Make default Rails version 7.X instead of 7.0.X

Open alexandreruban opened this issue 5 months ago • 2 comments

When trying to launch the Rails server with the Rails version set to the latest 7.0.X, it fails with the following error message:

uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)

The issue has been solved in Rails version 7.1.X, and so we should stop using the 7.0.X version as the default in development mode for the showcase engine.

I also dropped support for Rails 6.X and Ruby 2.X as they are not maintained anymore.

alexandreruban avatar Aug 03 '25 16:08 alexandreruban

We're a part of Bullet Train so there's a limit to what we can make the least supported versions. It still supports at least 6.0 https://github.com/bullet-train-co/bullet_train-core/blob/6de1416258ba5c8f1fa72090578f2a4ff9980b40/bullet_train/bullet_train.gemspec#L36

I'd be ok with making the least required Rails version 7.1 and Ruby 3.1. We should add the Ruby requirement to the gemspec too. @jagthedrummer do you have objections to that?

kaspth avatar Aug 10 '25 18:08 kaspth

@kaspth I think it's probably OK.

Our "support" for Rails 6 in BT is honestly probably more of an oversight than an intentional choice. In reality we don't really officially support any of the BT gems for use outside of a up-to-date starter-repo app. (Like we don't maintain old branches for the sake of doing security patches and what not.)

jagthedrummer avatar Aug 11 '25 18:08 jagthedrummer

Totally forgot about this, thanks @alexandreruban & @jagthedrummer!

kaspth avatar Dec 08 '25 17:12 kaspth