bullet_train icon indicating copy to clipboard operation
bullet_train copied to clipboard

Bullet Train now depends on devise 4.9.0

Open olbrich opened this issue 1 year ago • 2 comments

https://github.com/bullet-train-co/bullet_train/blob/7947b169b60367160b2844f8be8369faaca05cb7/Gemfile#L113

Because the devise initializer uses methods introduced in Devise 4.9.0, the Gemfile should now specify a minimum version for devise.

This was missed in the recent update of devise in #663

olbrich avatar Feb 26 '23 16:02 olbrich

Devise was updated, but we don't lock the version in the Gemfile specifically. You can see the diff in Gemfile.lock in the same PR, and you should be able to confirm the version by running bundle show devise.

gazayas avatar Feb 27 '23 08:02 gazayas

@gazayas You don't, but you should set a minimum version now. It's not possible to install an older version of devise because the initializer won't work with older versions.

BTW it is not uncommon during merging from upstream for bundler to recognize merge conflicts in Gemfile.lock. Its recommendation is to re-checkout the most recent HEAD version and run bundle install to rebuild it. If you don't specify a minimum version in the Gemfile then it won't update those dependencies.

olbrich avatar Feb 27 '23 14:02 olbrich

Since the Devise specific issue is resolved I'm going to close this.

I agree that we should be more specific in Gemfile about requirements. We can continue that discussion in https://github.com/bullet-train-co/bullet_train/issues/822.

jagthedrummer avatar Aug 29 '23 15:08 jagthedrummer