ta icon indicating copy to clipboard operation
ta copied to clipboard

Aroon Indicator uses wrong inputs and does not output values from 0 to 100

Open matstc opened this issue 4 years ago • 3 comments

The Aroon indicator should be using the highs and the lows and should output values from 0 to 100.

This code here uses the closes (which might be interesting as an option but not standard AFAIK)

The code also adds 1 to the index to make sure that the value can go up to 100 but by doing that, it cannot go down to 0 anymore. (Removing 1 from the window would take care of both cases.)

I'm not an expert trader so I might be misunderstanding something. Could anyone confirm that these are two issues with the Aroon indicator?

matstc avatar Aug 19 '21 12:08 matstc

Could anyone confirm that these are two issues with the Aroon indicator?

I also noticed this error you mentioned when I compared the values calculated by the program with signal values from other web sites. I will try to adjust the calculation based on low/high accordingly. (Unfortunately, I saw your issue just after I reported the same error in #315).

jennerwein avatar Feb 17 '23 09:02 jennerwein

I solved this issue in pull request https://github.com/bukosabino/ta/pull/316.

jennerwein avatar Feb 17 '23 16:02 jennerwein

Hi, I was trying to use the Aroon indicator and I think I found and issue that could be related to this one.

When I use the function the documentation says the only mandatory parameter is the close value, then when using it throws an error saying missing parameter 'low' (I don't know which one goes first in the function parameters).

Now that I read this conversation saying the indicator is based on high/low, shouldn't this function also need the high parameter?

I'm not an expert about this indicator and how it is calculated but my main problem was with the documentation that is outdated.

I'm using version 0.11.0.

AlexMedela avatar Apr 10 '24 16:04 AlexMedela