rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

RFC: Private Registry Mirrors

Open jabrown85 opened this issue 1 year ago • 6 comments

Readable

jabrown85 avatar May 24 '23 21:05 jabrown85

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

buildpack-bot avatar May 24 '23 21:05 buildpack-bot

What images are requested inside of the lifecycle?

loewenstein avatar Jun 09 '23 11:06 loewenstein

What images are requested inside of the lifecycle?

If the mirrors are available, I believe it would use the image from the mirror while the image will be written with the original source.

hone avatar Jun 09 '23 22:06 hone

What images are requested inside of the lifecycle?

Lifecycle talks directly to the registries about various images during the execution. One being the destined run-image for the image being built. For example, during the export phase, lifecycle creates an image manifest from the target run-image's manifest. Lifecycle has to talk to the run-image's registry to do this. If the run-image's registry is a public registry like dockerhub, it would consume request limits from that IP and be anonymous by default.

Lifecycle would also talk to the registry of the image being built in the same way as well as extension referenced images during that phase.

jabrown85 avatar Jun 12 '23 14:06 jabrown85

Understood. Thanks. I was wondering if there is anything else but run images that are pulled by the lifecycle, because we just recently contributed https://github.com/buildpacks/spec/pull/357 and https://github.com/buildpacks/lifecycle/pull/1024 to improve the handling of stack provided run image mirrors.

Should we add a similar provision here and state that

  1. Multiple mirrors could be defined
  2. The first site that is both reachable and readable is taken
  3. The original site is considered last

cc @natalieparellano @pbusko @c0d1ngm0nk3y

loewenstein avatar Jun 13 '23 06:06 loewenstein

Whoops, I mean to review this, not approve it (yet)

natalieparellano avatar Jun 25 '24 15:06 natalieparellano